[U-Boot] [PATCH v2] cmd_mtdparts.c: prevent printbuffer overflows

Anatolij Gustschin agust at denx.de
Tue Feb 23 16:18:30 CET 2010


The length of configured MTDPARTS_DEFAULT string
could be greater than console printbuffer size.
Replace printf() by puts() to avoid potential buffer
overflows.

Signed-off-by: Anatolij Gustschin <agust at denx.de>
---
Changes since v1:
 - use puts() instead of printf() as suggested by Wolfgang.

 common/cmd_mtdparts.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c
index b375fea..0fd5ce2 100644
--- a/common/cmd_mtdparts.c
+++ b/common/cmd_mtdparts.c
@@ -1254,8 +1254,9 @@ static void list_partitions(void)
 	printf("\ndefaults:\n");
 	printf("mtdids  : %s\n",
 		mtdids_default ? mtdids_default : "none");
-	printf("mtdparts: %s\n",
-		mtdparts_default ? mtdparts_default : "none");
+	puts("mtdparts: ");
+	puts(mtdparts_default ? mtdparts_default : "none");
+	puts("\n");
 }
 
 /**
-- 
1.6.3.3



More information about the U-Boot mailing list