[U-Boot] [PATCH] cmd_i2c.c: sorted commands alphabetically

Heiko Schocher hs at denx.de
Thu Feb 25 09:02:33 CET 2010


Hello Frans,

First, thanks for your patches! They look good to me,
just one nitpicking comment.

Frans Meulenbroeks wrote:
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
> ---
>  common/cmd_i2c.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c
> index e54fc20..1dd4df3 100644
> --- a/common/cmd_i2c.c
> +++ b/common/cmd_i2c.c
> @@ -1302,13 +1302,14 @@ int do_i2c(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>  U_BOOT_CMD(
>  	i2c, 6, 1, do_i2c,
>  	"I2C sub-system",
> -	"speed [speed] - show or set I2C bus speed\n"
>  #if defined(CONFIG_I2C_MUX)
> -	"i2c bus [muxtype:muxaddr:muxchannel] - add a new bus reached over muxes\n"
> +	"bus [muxtype:muxaddr:muxchannel] - add a new bus reached over muxes\ni2c "
>  #endif  /* CONFIG_I2C_MUX */
> +	"crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n"
>  #if defined(CONFIG_I2C_MULTI_BUS)
>  	"i2c dev [dev] - show or set current I2C bus\n"
>  #endif  /* CONFIG_I2C_MULTI_BUS */
> +	"i2c loop chip address[.0, .1, .2] [# of objects] - looping read of device\n"
>  	"i2c md chip address[.0, .1, .2] [# of objects] - read from I2C device\n"
>  	"i2c mm chip address[.0, .1, .2] - write to I2C device (auto-incrementing)\n"
>  	"i2c mw chip address[.0, .1, .2] value [count] - write to I2C device (fill)\n"
> @@ -1316,11 +1317,10 @@ U_BOOT_CMD(
>  	"i2c crc32 chip address[.0, .1, .2] count - compute CRC32 checksum\n"

You should delete this here, otherwise it will show the
"i2c crc32" command twice in this help list.

>  	"i2c probe - show devices on the I2C bus\n"
>  	"i2c reset - re-init the I2C Controller\n"
> -	"i2c loop chip address[.0, .1, .2] [# of objects] - looping read of device"
>  #if defined(CONFIG_CMD_SDRAM)
> -	"\n"
> -	"i2c sdram chip - print SDRAM configuration information"
> +	"i2c sdram chip - print SDRAM configuration information\n"
>  #endif
> +	"i2c speed [speed] - show or set I2C bus speed"
>  );
>  
>  #if defined(CONFIG_I2C_MUX)

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list