[U-Boot] [PATCH 2/2 rev2] ep93xx: Refactoring of timer code

Tom Tom.Rix at windriver.com
Fri Feb 26 01:13:34 CET 2010


Matthias Kaehlcke wrote:
> Hi Tom,
> 
> El Thu, Feb 25, 2010 at 09:54:59AM -0600 Tom ha dit:
> 
>> Matthias Kaehlcke wrote:
>>> ep93xx: Refactoring of the timer code, including the following changes
>>>
>>> * use a free running timer instead of a periodical one
>>> * use unsigned long long for total number of ticks
>>> * hold the timer state in a structure instead of separate variables
>>> * increment the timer counter instead of decrementing it
>>> * remove unused function udelay_masked()
>>> * remove unused function set_timer()
>>>
>>> Signed-off-by: Matthias Kaehlcke <matthias at kaehlcke.net>
>> This set has been applied to ARM.
> 
> i was/am working on a new version of the patch, taking into account
> your remarks about the unit of TIMER_FREQ and fixing some issues
> discussed with Alessandro Rubini off-list, who worked on a similar
> patch.
> 
> what do you prefer, a patch based on the ones you just applied, or
> revert them and get one with all fixes (only one patch, cause
> the function clk_to_systicks() fixed in the first patch of the set is
> removed)
> 
> i apologize for not having taken the time to notify about this and
> causing you overhead :(
> 
Its ok with me if you just rebase and submit a smaller patch.
Tom



More information about the U-Boot mailing list