[U-Boot] [PATCH] cmd_itest.c: also support environment variables as arguments

[Wolfgang Denk]

Dear Detlev Zundel,

In message <m2d3zstby2.fsf at ohwell.denx.de> you wrote:
> Hi Frans,
> 
> > Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
> > ---
> >  common/cmd_itest.c |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> >
> > diff --git a/common/cmd_itest.c b/common/cmd_itest.c
> > index 58c5e7b..78a4082 100644
> > --- a/common/cmd_itest.c
> > +++ b/common/cmd_itest.c
> > @@ -69,6 +69,10 @@ static long evalexp(char *s, int w)
> >  	long l = 0;
> >  	long *p;
> >  
> > +	/* if the parameter starts with a $ replace it with the environment value */
> > +	if (s[0] == '$') {
> > +		s = getenv(&s[1]);
> > +	}
> 
> This is actually a good idea, but I believe this does not work for the
> preferred ${variable} syntax, right?

... not to mention that it's fundamentally broken if the variable in
question is not an environment variable, but aplain hush shell
variable.

If you want variable subsitution, then please let the shell do this.
Don't reinvent the wheel.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember thee Ay, thou poor ghost while memory holds a seat  In  this
distracted  globe.  Remember  thee!  Yea, from the table of my memory
I'll wipe away all trivial fond  records,  All  saws  of  books,  all
forms,  all  pressures past, That youth and observation copied there.
Hamlet, I : v : 95 William Shakespeare