[U-Boot] [PATCH 03/10] 83xx/85xx/86xx: LBC register cleanup

[Becky Bruce]

On Jun 1, 2010, at 10:26 AM, Peter Tyser wrote:

> Hi Becky,
>
> On Fri, 2010-05-28 at 16:45 -0500, Becky Bruce wrote:
>> --- a/arch/powerpc/include/asm/config.h
>> +++ b/arch/powerpc/include/asm/config.h
>> @@ -76,4 +76,7 @@
>> /* Relocation to SDRAM works on all PPC boards */
>> #define CONFIG_RELOC_FIXUP_WORKS
>>
>> +/* Currently all plats have a local bus controller */
>> +#define CONFIG_FSL_LBC
>> +
>
> The above doesn't appear to break anything, but it seems a bit odd to
> define CONFIG_FSL_LBC for all PPC boards.  Would it be possible to  
> only
> define CONFIG_FSL_LBC and CONFIG_FSL_ELBC in config.h based on some
> CONFIG_MPCyyy conditionals and then get rid of patch 1/10 in this
> series?

Not really - the ELBC setting is quite specific and doesn't fall  
nicely on the lines of "MPC8qxx" vs "MPC8yxx".  It needs to be in the  
individual configs.

The LBC setting, though is nearly universal (but is not guaranteed  
going forward).  I can probably wrap that in a MPC86/85/83xx or  
something - I'll have to go check my specs to be sure I hit everyone  
that's affected.

-Becky