[U-Boot] [PATCH-V3 2/2] AM35x: Add support for EMIF4

[Hiremath, Vaibhav]

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Monday, May 31, 2010 3:14 PM
> To: Hiremath, Vaibhav
> Cc: u-boot at lists.denx.de; tom at bumblecow.com; Paulraj, Sandeep; Premi,
> Sanjeev
> Subject: Re: [PATCH-V3 2/2] AM35x: Add support for EMIF4
> 
> Dear hvaibhav at ti.com,
> 
> In message <1273166585-26101-2-git-send-email-hvaibhav at ti.com> you wrote:
> > From: Vaibhav Hiremath <hvaibhav at ti.com>
> >
> > This patch adds support for the EMIF4 interface
> > available in the AM35x processors.
> >
> > Changes from V2:
> > 	- Removed all instances of #ifdef CONFIG_EMIF4
> 
> See previeos comment - such comments belong below the "---" line and
> not into the commit message.
> 
[Hiremath, Vaibhav] OK, I will incorporate changes in next post.

> > diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > index 1e80eb3..d25bfd5 100644
> > --- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > +++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile
> > @@ -38,6 +38,7 @@ COBJS	+= sys_info.o
> >  COBJS	+= timer.o
> >
> >  COBJS-$(CONFIG_SDRC)	+= sdrc.o
> > +COBJS-$(CONFIG_EMIF4)	+=emif4.o
> 
> Please keep lists sorted.
> 
[Hiremath, Vaibhav] Will change and submit it again.

Thanks,
Vaibhav

> 
> Best regards,
> 
> Wolfgang Denk
> 
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> The complexity of software is an essential property, not an  acciden-
> tal  one. Hence, descriptions of a software entity that abstract away
> its complexity often abstract away its essence.    - Fred Brooks, Jr.