[U-Boot] [PATCH] [v2] tsec: fix the return value for tsec_eth_init() and tsec_standard_init()

[Mike Frysinger]

On Tuesday, June 08, 2010 10:34:28 Timur Tabi wrote:
> Mike Frysinger wrote:
> > the documentation currently states that a negative value is permissible
> > and thus "int" is correct.  as for the code that actually reads the
> > result, that is by & large common code, so logic along those lines isnt
> > terribly important.
> 
> The conclusion I drew from Andy's comments is that functions which
> initialize more than one device should not return a negative value.  That
> makes sense to me.  Perhaps the documentation should be updated to
> incorporate this idea?

the code and documentation need to be updated in lock step, after we agree on 
the direction to take.  i dont have a problem with picking a direction and 
going for it, but i do have a problem with things once again falling out of 
sync and no one having a f-ing clue what's going on because there's no 
reliable documentation and drivers dont match each other.

i think the direction people are leaning towards is to completely ignore all 
errors from net drivers and let u-boot continue to load.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100608/decbd08e/attachment.pgp