[U-Boot] [PATCH 08/10] ARMV7: Restructure OMAP i2c driver to allow code sharing between OMAP3 and OMAP4

Heiko Schocher hs at denx.de
Thu Jun 17 07:15:56 CEST 2010


Hello Steve,

Steve Sakoman wrote:
> On Mon, Jun 14, 2010 at 11:47 PM, Heiko Schocher <hs at denx.de> wrote:
> 
>> Instead of making here a third copy of this defines, we
>> should make a common omap i2c.h file, which collects all
>> common defines, and only add in this file here the
>> specific defines.
>>
>> This applies to a lot of defines below. Please
>> clean up, thanks!
> 
> Thanks for the comments.  I made the changes and I'm preparing a
> version 2 patch.

Thanks.

> A quick procedure question.  Should I post individual version 2 patch
> replies for each patch in the series that has received comments, or is
> it preferred to post a complete version 2 series?  I see both
> approaches used on the list so I'm a bit confused which is proper.

I have no preference, both seems Ok to me. Say you have to make
for some patches a version 2, 3, 4 and they fit together with
lower versions from other patches from your patch series, it is
okay to post only individual versions, but the complexity can grow,
mainline code changes, so it could make sense to post the complete
patch series again.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list