[U-Boot] ns16550.c compile problem

[Sergej.Stepanov at ids.de]

Hi All!

Trying to update u-boot(1.3.3) to u-boot2010 we got the following compile problem:

ppc_8xx-gcc  -g  -Os   -mrelocatable -fPIC -meabi -D__KERNEL__ -DTEXT_BASE=0x40700000 -I/home/ste/Develop/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/eldk-4.2/usr/bin/../lib/gcc/powerpc-linux/4.2.2/include -pipe  -DCONFIG_PPC -D__powerpc__ -DCONFIG_8xx -ffixed-r2 -mstring -mcpu=860 -msoft-float -Wall -Wstrict-prototypes -fno-stack-protector   \
                -o ns16550.o ns16550.c -c
In file included from ns16550.c:9:
/home/ste/Develop/u-boot/include/watchdog.h:75: warning: type defaults to 'int' in declaration of 'immap_t'
/home/ste/Develop/u-boot/include/watchdog.h:75: error: expected ';', ',' or ')' before '*' token
make[1]: *** [ns16550.o] Fehler 1

We use ELDK-4.2.

It could be fixed with the patch:

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 7e833fd..f951f05 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -4,6 +4,7 @@
  * modified to use CONFIG_SYS_ISA_MEM and new defines
  */
 
+#include <common.h>
 #include <config.h>
 #include <ns16550.h>
 #include <watchdog.h>


Is there are any other way?
All other serial drivers have the "common.h"-include.

Regards
Sergej.