[U-Boot] ns16550.c compile problem

[Wolfgang Denk]

Dear Sergej.Stepanov at ids.de,

In message <4206182445660643B9AEB8D4E55BBD0A1061C6A814 at HERMES2> you wrote:
>
> what do you say If i propose a patch for it:
>
> diff --git a/include/watchdog.h b/include/watchdog.h
> index b959914..29439fa 100644
> --- a/include/watchdog.h
> +++ b/include/watchdog.h
> @@ -70,11 +70,6 @@
>   * Prototypes from $(CPU)/cpu.c.
>   */
>  
> -/* MPC 8xx */
> -#if (defined(CONFIG_8xx) || defined(CONFIG_MPC860)) && !defined(__ASSEMBLY__)
> -	void reset_8xx_watchdog(volatile immap_t *immr);
> -#endif
> -
>  /* MPC 5xx */
>  #if defined(CONFIG_5xx) && !defined(__ASSEMBLY__)
>  	void reset_5xx_watchdog(volatile immap_t *immr);
>
>
> The reset_8xx_watchdog(..) is not really needed here.

But you are deleting a prototype declaration which is completely
harmless. If you want to clean up, just deletethe "#if" and "#endif"
lines which are not needed.

> I have to say it may be wrong for other boards, but for NC650-board it helps.

I cannot imagine how this prototype might be connected with your
actual problem, but I am pretty sure that your proposed fix is wrong.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is an old custom among my people. When a woman  saves  a  man's
life, he is grateful.
	-- Nona, the Kanuto which woman, "A Private Little War",
	   stardate 4211.8.