[U-Boot] [PATCH] include/compiler.h: remove redunandt declaration of errno

Mike Frysinger vapier at gentoo.org
Sun Jun 20 03:58:40 CEST 2010


On Saturday, June 19, 2010 20:20:33 y at denx.de wrote:
> Commit 37566090 "compiler.h: unify system ifdef cruft here" added both
> a "#include <errno.h>" and a "extern int errno;" to include/compiler.h

it isnt new code, it sucked the definitions out of random files that had these 
and into one place

> which is causing build warnings for some systems, for example for the
> "netstar" board:
> 
> 	In file included from /home/wd/git/u-boot/work/lib/crc32.c:15:
> 	include/compiler.h:28: warning: function declaration isn't a prototype

never seen that, but i imagine re-ordering the lines might address it as well 
(extern then include)

> The declaration of "errno" should be redundant, as <errno.h> is
> supposed to provide a correct declaration, so drop it.

there are older systems where this isnt true, but ive never used one myself 
and if we dont care about them (i dont), then this is fine
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100619/f9e6bbfb/attachment.pgp 


More information about the U-Boot mailing list