[U-Boot] [PATCH 1/2] NAND: show manufacturer and device ID for unknown chips

Scott Wood scottwood at freescale.com
Mon Jun 21 18:49:14 CEST 2010


On Sun, Jun 20, 2010 at 03:40:55PM +0200, Florian Fainelli wrote:
> Le Saturday 12 June 2010 20:59:25, Florian Fainelli a écrit :
> > When the NAND part is not supported, it is useful to show the manufacturer
> > and device ID to help debugging and reporting.
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli at gmail.com>
> 
> Scott, anything from with the patch? Thanks!

I just got back from vacation, but the patches look reasonable.  

> > ---
> > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> > index 7171bdd..c1657de 100644
> > --- a/drivers/mtd/nand/nand_base.c
> > +++ b/drivers/mtd/nand/nand_base.c
> > @@ -2652,8 +2652,12 @@ static struct nand_flash_dev
> > *nand_get_flash_type(struct mtd_info *mtd, }
> >  	}
> > 
> > -	if (!type)
> > +	if (!type) {
> > +		printk(KERN_INFO "%s: unknown NAND device: Manufacturer ID :"

I'd leave out the space before the colon ("foo: bar", not "foo : bar"),
though.  I think that may be a regional style issue, but let's stick with
what the rest of the code does.

-Scott


More information about the U-Boot mailing list