[U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO writel arguments

[Prafulla Wadaskar]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud
> Sent: Tuesday, June 22, 2010 2:17 AM
> To: u-boot at lists.denx.de
> Subject: [U-Boot] [PATCH] Fix wrong orion5x MPP and GIPO 
> writel arguments
> 
> 
> Signed-off-by: Albert Aribaud <albert.aribaud at free.fr>
> ---
> Orion5x MPP and GPIO setting code had writel arguments
> the wrong way around. Fixed and tested.
> 
>  arch/arm/cpu/arm926ejs/orion5x/cpu.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/orion5x/cpu.c 
> b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> index c2f5253..03c6d06 100644
> --- a/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> +++ b/arch/arm/cpu/arm926ejs/orion5x/cpu.c
> @@ -260,10 +260,10 @@ int arch_misc_init(void)
>  
>  	/* Set CPIOs and MPPs - values provided by board
>  	   include file */
> -	writel(ORION5X_MPP_BASE+0x00, ORION5X_MPP0_7);
> -	writel(ORION5X_MPP_BASE+0x04, ORION5X_MPP8_15);
> -	writel(ORION5X_MPP_BASE+0x50, ORION5X_MPP16_23);
> -	writel(ORION5X_GPIO_BASE+0x04, ORION5X_GPIO_OUT_ENABLE);
> +	writel(ORION5X_MPP0_7, ORION5X_MPP_BASE+0x00);
> +	writel(ORION5X_MPP8_15, ORION5X_MPP_BASE+0x04);
> +	writel(ORION5X_MPP16_23, ORION5X_MPP_BASE+0x50);
> +	writel(ORION5X_GPIO_OUT_ENABLE, ORION5X_GPIO_BASE+0x04);

This means, earlier patches you posted were not tested properly.
Its great trust on the developers that whatever they submit (even smallest change) is tested.
Submitting untested/unused code is strongly discouraged...

I hope everyone agrees with me.

Regards..
Prafulla . .