[U-Boot] [PATCH][RESEND] 85xx/p1_p2_rdb: Added RevD board support.

[Wolfgang Denk]

Dear Poonam Aggrwal,

In message <1277186281-5276-1-git-send-email-poonam.aggrwal at freescale.com> you wrote:
>   - Removed RevB, as it was a development stage board.
>   - From now only RevC and RevD will be supported.
> 
> Signed-off-by: Dipen Dudhat <dipen.dudhat at freescale.com>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal at freescale.com>

Thanks for the quick update, but did you read my comments?


>  unsigned long get_board_sys_clk(ulong dummy)
>  {
>  	volatile ccsr_gpio_t *pgpio = (void *)(CONFIG_SYS_MPC85xx_GPIO_ADDR);
> -	u32 val_gpdat, sysclk_gpio, board_rev_gpio;
> +	u32 val_gpdat, sysclk_gpio;
>  
>  	val_gpdat = pgpio->gpdat;

Please use I/O accessors to read from peripherals!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Its always easier short term to pee in the pond
than install a toilet - it's just not a good long term plan.
          - Alan Cox in <20100101145701.6432e7b7 at lxorguk.ukuu.org.uk>