[U-Boot] [PATCH] add support for EMK TOP7000 CPU module (modified files)

[Wolfgang Denk]

Dear "Reinhard Meyer (-VC)",

In message <4C09274B.2080901 at emk-elektronik.de> you wrote:
>
> Well, what about that situation (two names as maintainers for HAMMERHEAD),
> where do I sort in?
> 
> Mark Jackson <mpfj at mimc.co.uk>
> 
>     MIMC200            AT32AP7000
> 
> Alex Raimondi <alex.raimondi at miromico.ch>
> Julien May <julien.may at miromico.ch>

First name counts, i. e. this entry should sort as "Alex Raimondi".

> > Please add mail address
> >   
> I can do that. But is it really senseful to add an email address to each 
> file?
> E-Mail adresses can change. Also "Rechtsform" (GmbH -> GmbH & Co. KG).
> Shall that all be reflected in a simple copyright string?

It makes a lot of sense to the reader of the code, even i=f it should
change later (when the code is properly maintained, such entries
should get updated, too).

> >> @@ -68,12 +69,56 @@ void read_factory_r (void)
> >>          addr += p - buf;
> >>          /*printf ("%s\n", buf); */
> >>          /* search for our specific entry */
> >> -        if (!strncmp ((char *) buf, "[RLA/lan/Ethernet] ", 19)) {
> >> +        if (!strncmp ((char *) buf, "[RLA/lan/Ethernet] ", 19))
> >>              setenv ("ethaddr", (char *)(buf + 19));
> >> -        } else if (!strncmp ((char *) buf, "[BOARD/SERIAL] ", 15)) {
> >> +#if defined(CONFIG_TOP7000)
> >> +        /* boards that have 2 LAN interfaces */
> >> +        else if (!strncmp ((char *) buf, "[RLA/lan2/Ethernet] ", 20))
> >> +            setenv ("eth1addr", (char *)(buf + 20));
> >> +#endif
> >>     
> >
> > Curly braces are needed for multiline statements.
> >   
> Not sure what is multiline here? its like

Your code (ignoring the ifdef):

	if (!strncmp ((char *) buf, "[RLA/lan/Ethernet] ", 19))
		setenv ("ethaddr", (char *)(buf + 19));
	/* boards that have 2 LAN interfaces */
	else if (!strncmp ((char *) buf, "[RLA/lan2/Ethernet] ", 20))

To me this is multi-line, and badly indented, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
365 Days of drinking Lo-Cal beer.                       = 1 Lite-year