[U-Boot] [PATCH 0/6] Update kirkwood egiga to allow dynamic phy addrs

Wolfgang Denk wd at denx.de
Thu Jun 24 11:14:43 CEST 2010


Dear Tor Krill,

In message <1277370025-17281-1-git-send-email-tor at excito.com> you wrote:
> Today the kirkwood egiga driver assumes that phy addresses are 
> consecutive from a base address.
> 
> Our new board design using this cpu unfortunately has a non contiguous
> addressing of its phys and thus doesn't work with the current
> implementation.
> 
> This patchset updates the implementation to use an array of
> phy addresses as configuration.
> 
> Tor Krill (6):
>   Allow PHY addresses on kirkwood egiga to be non continuous.
>   Convert Suen3 board to use array of phy addrs
>   Convert Sheevaplug board to use array of phy addrs
>   Convert OpenRD board to use array of phy addrs
>   Convert Guruplug board to use array of phy addrs
>   Convert rd6281a board to use array of phy addrs

Looking at what you are doing, things get even worse.

This is an atomic change. This must be submitted as a single patch,
not split into separate patches. Please read the documentatin and
stick to the rules!


NAK!!


Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Successful and fortunate crime is called virtue.             - Seneca


More information about the U-Boot mailing list