[U-Boot] [PATCH V2] Allow PHY addresses on kirkwood egiga to be non continuous.

Wolfgang Denk wd at denx.de
Mon Jun 28 14:02:07 CEST 2010


Dear Tor Krill,

In message <1277716302.2221.37.camel at tor-desktop> you wrote:
>
> > 2. For the boards using single port will also need to configure PHY address
> >  for other port, which is meaningless, unnecessary and confusing.
> 
> Sure you had to put something there to be on the safe side. But is that
> really that confusing, the SOC really have two ports, them being used or
> not? 

It is indeed confusing and should be avoided if one has to configurwe
hardware ports that are not actually present or used on a specific
board.

If needed, provide sane defaults internally in the code.

But keep in mind that U-Boot requires that only used peripherals
should be initialized - we should not initisalize any unused ports.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Let's say the docs present a simplified view of reality...    :-)
                      - Larry Wall in  <6940 at jpl-devvax.JPL.NASA.GOV>


More information about the U-Boot mailing list