[U-Boot] [PATCH] MPC512x: workaround data corruption for unaligned local bus accesses

Wolfgang Denk wd at denx.de
Tue Jun 29 14:09:45 CEST 2010


Dear Detlev Zundel,

In message <m2vd9283ew.fsf at ohwell.denx.de> you wrote:
> 
> Acked-by: Detlev Zundel <dzu at denx.de>

thanks.

> The only thing I wonder is the filename 'memcpy_mpc5200.c' as the code
> doesn't really have any 5200 specifics in it.  What about

As far as I understand this behaviour is specific to the MPC512x and
MPC5200 processors; I did not notice it on other cores yet.
Unfortunately we do not have a generic name that includes these
processors (5xxx is taken by something else).

> 'memcpy_align32wrap' or something likew that to express the more general
> nature of the code?

I could not come up with a better name... What is "align32wrap"
supposed to mean?

> If one thinks further along this line, why not move the wrapper to lib/? 

Please re-check what my patch does - exactly that:

>  arch/powerpc/{cpu/mpc5xxx => lib}/memcpy_mpc5200.c |    0


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The value of marriage is not that adults produce children, but  that
children produce adults."                            - Peter De Vries


More information about the U-Boot mailing list