[U-Boot] [PATCH 3/3 v6] SAMSUNG: SMDKC100: Adds ethernet support.

Minkyu Kang promsoft at gmail.com
Tue Mar 2 05:28:02 CET 2010


Dear Naveen Krishna Ch,

On 1 March 2010 14:05, Naveen Krishna Ch <naveenkrishna.ch at gmail.com> wrote:
> Hi kang,
>
> On 26 February 2010 21:21, Minkyu Kang <promsoft at gmail.com> wrote:
>>
>> Dear Naveen Krishna CH,
>>
>> On 26 February 2010 20:47,  <ch.naveen at samsung.com> wrote:
>> > From: Naveen Krishna CH <ch.naveen at samsung.com>
>> >
>> > Add setup for ethernet on SMDKC100, allowing kernel/ramdisk to be
>> > loaded over tftp.
>> >
>> > The preinit function will configure GPIO (GPK0CON) & SROMC to look
>> > for environment in SROM Bank 3.
>> >
>> > Signed-off-by: Naveen Krishna Ch <ch.naveen at samsung.com>
>> > ---
>> > Changes since V1:
>> >
>> > 1. The CONFIG_BOOTP* and Net config Macros are removed from config
>> > header.
>> > Comments from Ben Warren are fixed
>> > 2. The GPIO configuration is modified & Macro and Function are renamed.
>> > Comments from Minkyu Kang are fixedChanges since V2
>> >
>> > Changes since V2:
>> > 1. GPIO configurations function has been implemented.
>> >
>> > Changes since V3:
>> > 1. Comments from Minkyu Kang are fixed.
>> >
>> > Changes since V4:
>> > None
>> >
>> > Changes since v5:
>> > 1. Compile time warning are fixed.
>> >
>> >  board/samsung/smdkc100/smdkc100.c |   40
>> > +++++++++++++++++++++++++++++++++++++
>> >  include/configs/smdkc100.h        |   12 ++++++++++-
>> >  2 files changed, 51 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/board/samsung/smdkc100/smdkc100.c
>> > b/board/samsung/smdkc100/smdkc100.c
>> > index 15a1a27..76bd4cc 100644
>> > --- a/board/samsung/smdkc100/smdkc100.c
>> > +++ b/board/samsung/smdkc100/smdkc100.c
>> > @@ -23,10 +23,41 @@
>> >  */
>> >
>> >  #include <common.h>
>> > +#include <asm/io.h>
>> > +#include <asm/arch/smc.h>
>> > +#include <asm/arch/gpio.h>
>> > +#include <netdev.h>
>> > +
>> >  DECLARE_GLOBAL_DATA_PTR;
>> >
>> > +/*
>> > + * Miscellaneous platform dependent initialisations
>> > + */
>> > +static void smc9115_pre_init(void)
>> > +{
>> > +       u32 tmp;
>>
>> Why didn't delete this variable?
>
> My Bad, Patch replaced. Can i send this one alone as v6 or
> should i send the patch set again as v7

Please send next version.

>>
>> > +       u32 smc_bw_conf, smc_bc_conf;
>> > +
>> > +       struct s5pc100_gpio *const gpio =
>> > +               (struct s5pc100_gpio *)S5PC100_GPIO_BASE;
>> > +
>> > +       /* gpio configuration GPK0CON */
>> > +       gpio_cfg_pin(&gpio->gpio_k0, CONFIG_ENV_SROM_BANK,
>> > GPIO_FUNC(2));
>> > +
>> > +       /* Ethernet needs bus width of 16 bits */
>> > +       smc_bw_conf = SMC_DATA16_WIDTH(CONFIG_ENV_SROM_BANK);
>> > +       smc_bc_conf = SMC_BC_TACS(0x0) | SMC_BC_TCOS(0x4) |
>> > SMC_BC_TACC(0xe)
>> > +                       | SMC_BC_TCOH(0x1) | SMC_BC_TAH(0x4)
>> > +                       | SMC_BC_TACP(0x6) | SMC_BC_PMC(0x0);
>> > +
>> > +       /* Select and configure the SROMC bank */
>> > +       s5pc1xx_config_sromc(CONFIG_ENV_SROM_BANK, smc_bw_conf,
>> > smc_bc_conf);
>> > +}
>> > +
>>
>> Thanks
>> Minkyu Kang
>> --
>> from. prom.
>> www.promsoft.net
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
>
> --
> Shine bright,
> (: Naveen Krishna Ch :)
>

Thanks
Minkyu Kang
-- 
from. prom.
www.promsoft.net


More information about the U-Boot mailing list