[U-Boot] [PATCH] add new board pm9g45
RONETIX - Asen Dimov
dimov at ronetix.at
Wed Mar 17 21:06:19 CET 2010
Hello Wolfgang,
in the message <20100316190012.84CA75086C at gemini.denx.de> form
16.03.2010 at 09:00 PM
>> +#ifdef CONFIG_LCD
>> +/*
>> + * LCD name TX09D50VM1CCA
>> + */
>> +vidinfo_t panel_info = {
>> + vl_col: 240,
>> + vl_row: 320,
>> + vl_clk: 4965000,
>> + vl_sync: ATMEL_LCDC_INVLINE_NORMAL |
>> + ATMEL_LCDC_INVFRAME_NORMAL,
>> + vl_bpix: 3,
>> + vl_tft: 1,
>> + vl_hsync_len: 5,
>> + vl_left_margin: 1,
>> + vl_right_margin:33,
>> + vl_vsync_len: 1,
>> + vl_upper_margin:1,
>> + vl_lower_margin:0,
>> + mmio: AT91SAM9G45_LCDC_BASE,
>> +};
>>
>
> This information should not be board-specific. The panel information
> is generic and should moved to a separate header file that is not part
> of the board code.
>
>
>
In the boards (at91sam9263ek and at91sam9m10g45ek, and some more
at91sam9 based boards) I am looking at, the panel_info is in the board
specific code.
There are some lcd.c files with panel_info structures:
drivers/video/mx3fb.c, cpu/pxa/pxafb.c and cpu/mpc8xx/lcd.c .
Where should be the proper place for panel_info which is somehow
architecture dependent?
Regards,
Asen
More information about the U-Boot
mailing list