[U-Boot] [PATCH 07/13] ColdFire: Update Extra environment Data for M5275EVB

[Ben Warren]

TsiChung,

On Wed, Mar 17, 2010 at 6:39 PM, TsiChung Liew <tsicliew at gmail.com> wrote:

> Provide extra environment Data and default network address
>
> Signed-off-by: TsiChung Liew <tsicliew at gmail.com>
> ---
>  include/configs/M5275EVB.h |   28 +++++++++++++++++++++++-----
>  1 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/include/configs/M5275EVB.h b/include/configs/M5275EVB.h
> index b380159..f733a4d 100644
> --- a/include/configs/M5275EVB.h
> +++ b/include/configs/M5275EVB.h
> @@ -121,11 +121,6 @@
>  #define CONFIG_SYS_I2C_PINMUX_CLR      (0xFFF0)
>  #define CONFIG_SYS_I2C_PINMUX_SET      (0x000F)
>
> -#ifdef CONFIG_MCFFEC
> -#define CONFIG_ETHADDR         00:06:3b:01:41:55
> -#define CONFIG_ETH1ADDR                00:0e:0c:bc:e5:60
> -#endif
> -
>  #define CONFIG_SYS_PROMPT              "-> "
>  #define CONFIG_SYS_LONGHELP            /* undef to save memory */
>
> @@ -145,6 +140,29 @@
>  #define CONFIG_SYS_MEMTEST_START       0x400
>  #define CONFIG_SYS_MEMTEST_END         0x380000
>
> +#ifdef CONFIG_MCFFEC
> +#      define CONFIG_NET_RETRY_COUNT   5
> +#      define CONFIG_ETHADDR   00:06:3b:01:41:55
> +#      define CONFIG_ETH1ADDR  00:0e:0c:bc:e5:60
> +#      define CONFIG_IPADDR    192.162.1.2
> +#      define CONFIG_NETMASK   255.255.255.0
> +#      define CONFIG_SERVERIP  192.162.1.1
> +#      define CONFIG_GATEWAYIP 192.162.1.1
>
Please get rid of all default MAC and IP addresses.  MAC addresses need to
be unique, and you're making probably invalid assumptions about the
end-user's network.

> +#      define CONFIG_OVERWRITE_ETHADDR_ONCE
> +#endif                         /* FEC_ENET */
> +
> +#define CONFIG_EXTRA_ENV_SETTINGS              \
> +       "netdev=eth0\0"                         \
> +       "loadaddr=10000\0"                      \
> +       "uboot=u-boot.bin\0"                    \
> +       "load=tftp ${loadaddr} ${uboot}\0"      \
> +       "upd=run load; run prog\0"              \
> +       "prog=prot off ffe00000 ffe3ffff;"      \
> +       "era ffe00000 ffe3ffff;"                \
> +       "cp.b ${loadaddr} ffe00000 ${filesize};"\
> +       "save\0"                                \
> +       ""
> +
>  #define CONFIG_SYS_HZ                  1000
>  #define CONFIG_SYS_CLK                 150000000
>
> regards,
Ben