[U-Boot] [PATCH] MX51: Moved board specific values in config file

[Tom]

Stefano Babic wrote:
> The lowlevel_init file contained some hard-coded values
> to setup the RAM. These board related values are moved into
> the board configuration file.

Why was only one value cleaned up?
Just from the patch, there are at least 4 more.

> 
> Signed-off-by: Stefano Babic <sbabic at denx.de>
> ---
>  cpu/arm_cortexa8/mx51/lowlevel_init.S |    5 ++++-
>  include/configs/mx51evk.h             |    3 +++
>  2 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/cpu/arm_cortexa8/mx51/lowlevel_init.S b/cpu/arm_cortexa8/mx51/lowlevel_init.S
> index 31af9e2..1e393bb 100644
> --- a/cpu/arm_cortexa8/mx51/lowlevel_init.S
> +++ b/cpu/arm_cortexa8/mx51/lowlevel_init.S
> @@ -158,6 +158,7 @@
>  	/* Switch peripheral to PLL 3 */
>  	ldr r0, =CCM_BASE_ADDR
>  	ldr r1, =0x000010C0
> + 	orr r1,r1,#CONFIG_SYS_DDR_CLKSEL

git am complains about the leading space
Please remove
>  	str r1, [r0, #CLKCTL_CBCMR]
>  	ldr r1, =0x13239145
>  	str r1, [r0, #CLKCTL_CBCDR]
> @@ -171,6 +172,7 @@
>  	ldr r1, =0x19239145
>  	str r1, [r0, #CLKCTL_CBCDR]
>  	ldr r1, =0x000020C0
> +	orr r1,r1,#CONFIG_SYS_DDR_CLKSEL

This is a noop as it is defined as 0.
Is the value going to change ?

Tom