[U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

[Mike Frysinger]

On Wednesday 24 March 2010 08:52:26 Detlev Zundel wrote:
> What Heiko _really_ fixes is that the board has a problem with linux
> when no network transfer was done in U-Boot.  Looking at the code, this
> is quite obvious as this special driver does not program any mac address
> into the controller when no EEPROM mac is found.

which is correct

> No one could argue that Linux should initialize that, but given our
> failed attempts to fix such things in the ARM linux tree, I looked for
> another solution.

read the FAQ and/or talk to Wolfgang

> Looking into our network code again I found doc/README.drivers.eth.  It
> is explicitely allowed in this document to program a mac address into
> the controller.

i dont think you read the document correctly.  it says program the driver MAC 
address in the init function using eth_device->enetaddr, not the environment, 
and not the initialize function.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100324/39dceb97/attachment.pgp