[U-Boot] [PATCH 3/4] SPEAr : Network driver support added

[Ben Warren]

Hi Vipin,

On Wed, Mar 24, 2010 at 9:48 PM, Vipin KUMAR <vipin.kumar at st.com> wrote:

> On 3/23/2010 11:09 PM, Ben Warren wrote:
> > Hi Vipin,
>
> Hello Ben,
>
> > On 3/23/2010 1:30 AM, Vipin KUMAR wrote:
> >> SPEAr SoCs support a synopsys network peripheral. This patch adds the
> >> support
> >> for the same
> >>
> >>    Signed-off-by: Vipin Kumar<vipin.kumar at st.com>
> >> ---
> >>   board/spear/spear300/spear300.c          |    6 +
> >>   board/spear/spear310/spear310.c          |    6 +
> >>   board/spear/spear320/spear320.c          |    6 +
> >>   board/spear/spear600/spear600.c          |    6 +
> >>   drivers/net/Makefile                     |    1 +
> >>   drivers/net/spr_eth_syn.c                |  471
> >> ++++++++++++++++++++++++++++++
> >>   include/asm-arm/arch-spear/hardware.h    |    2 +
> >>   include/asm-arm/arch-spear/spr_eth_syn.h |  262 +++++++++++++++++
> >>   include/configs/spear-common.h           |   24 ++-
> >>   include/configs/spear3xx.h               |    3 +
> >>   include/netdev.h                         |    1 +
> >>   11 files changed, 785 insertions(+), 3 deletions(-)
> >>   create mode 100755 drivers/net/spr_eth_syn.c
> >>   create mode 100644 include/asm-arm/arch-spear/spr_eth_syn.h
> >>
> >>
>
<snip>

> >>
> >> +/* Ethernet configuration */
> >> +#define CONFIG_SPEAR_ETHERNET
> >> +#define CONFIG_MII
> >> +#define CONFIG_NET_MULTI
> >> +#define CONFIG_PHY_RESET_DELAY            (10000)        /* in us */
> >> +#define CONFIG_EXTRA_ENV_AUTONEG        "ethautoneg=n\0"
> >> +#define CONFIG_EXTRA_ENV_ETHSPEED        "ethspeed=100M\0"
> >> +#define CONFIG_EXTRA_ENV_ETHDUPLEX        "ethduplex=full\0"
> >> +#define CONFIG_ETHADDR                00:80:E1:11:22:33
> >> +#define CONFIG_NETMASK                255.255.255.0
> >> +#define CONFIG_IPADDR                192.168.1.10
> >> +#define CONFIG_SERVERIP                192.168.1.1
> >>
> > Please remove all default addresses/masks
>
> Could not understand this point. These definitions are needed and are
> done in the same way in board configuration files.
> Am I missing something ?
>
> The MAC and IP addresses are not needed.  You'll be able to find lots of
discussions on the ML, but here's the deal anyway:

1. MAC addresses must be unique, and this isn't.  In addition, the one that
you've specified has been paid for by some organization (maybe yours, but
I'm too lazy to look it up), with the understanding that it will be used on
one physical MAC.

2. IP addresses are specific to a network.  More likely than not, the end
user of this device will not use this subnet, so what's the point?

Recommended practice is to program network parameters at first boot-up using
'setenv'.

Thanks for the submission!
Ben