[U-Boot] unneeded exported function i2c_mux_add_device
Heiko Schocher
hs at denx.de
Thu Mar 25 07:39:06 CET 2010
Hello Frans,
Frans Meulenbroeks wrote:
> While grepping some sources I bumped upon i2c_mux_add_device
> This one is implemented in cmd_i2c.c and exported through i2c.h.
> However no-one outside cmd_i2c.c is using it:
>
> frans at linux-suse:~/u-boot> grep -r i2c_mux_add_device .
> ./common/cmd_i2c.c:int i2c_mux_add_device(I2C_MUX_DEVICE *dev)
> ./common/cmd_i2c.c: i2c_mux_add_device (device);
> ./include/i2c.h:int i2c_mux_add_device(I2C_MUX_DEVICE *dev);
> frans at linux-suse:~/u-boot>
>
> Should we make this function static and remove from the .h file?
Yep, good catch. Please post a patch.
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
More information about the U-Boot
mailing list