[U-Boot] Rejected: [PATCH v2] nios2: flush data cache after relocating code in start.S

Scott McNutt smcnutt at psyent.com
Thu Mar 25 14:11:26 CET 2010


Hi Thomas,

Patch is reject.


> diff --git a/cpu/nios2/start.S b/cpu/nios2/start.S
> index 31cd5b0..61784d8 100644
> --- a/cpu/nios2/start.S
> +++ b/cpu/nios2/start.S
> @@ -98,6 +98,17 @@ _cur:	movhi	r5, %hi(_cur - _start)
>  	stwio	r7, 0(r5)
--------^^^^^

The existing code uses stxio instructions, which by their
very purpose, bypass the cache. So there's no need to flush
the data cache.

One could argue that invalidating the _instruction_ cache
may be necessary ... but I doubt it, given that first
instructions after reset invalidate the entire instruction
cache. It would be a defensive nevertheless.

Regards,
--Scott


More information about the U-Boot mailing list