[U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Wolfgang Denk wd at denx.de
Thu Mar 25 15:02:02 CET 2010


Dear Detlev Zundel,

In message <m2tys4k0c8.fsf at ohwell.denx.de> you wrote:
> 
> > The question to me is why fec_probe() is called at all, even in cases
> > where U-Boot does not use any network related commands. This is IMO
> > wrong. Eventually somebody comes up with patches to fix this?
> 
> As I said before, this is documented in doc/README.drivers.eth.  If you
> want to change this, then maybe one should first fix the documentation

I think the documentation should be changed when the code gets
changed, not sooner nor later.

> to know what is actually wanted.  I certainly have lost track of what is
> wanted and what is sensible.

We do not want to touch interfaces that we don't use. If we don't use
Ethernet in U-Boot, there is no need to probe or initialize it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Love your country but never trust its government."
- from a hand-painted road sign in central Pennsylvania


More information about the U-Boot mailing list