[U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

[Mike Frysinger]

On Thursday 25 March 2010 15:11:10 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > The question to me is why fec_probe() is called at all, even in cases
> > > where U-Boot does not use any network related commands. This is IMO
> > > wrong. Eventually somebody comes up with patches to fix this?
> > 
> > the current fec_mxc driver has squashed the initialize and probe steps. 
> > it should have half the things removed from probe and put into
> > initialize and then the call to probe moved to the init step.
> 
> OK - but why should we always probe?

i merely mean that the structure set up and enetaddr seeding should be split 
out into the initialize function.  as for the contents of probe vs init and 
how much the driver should "probe" the hw, i leave that up to the fec_mxc 
maintainer -- i have no vested interest in this driver beyond the common eth 
interface.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100325/9c8fb9f4/attachment.pgp