[U-Boot] net, fec_mxc: init mac address before using network commands

Mike Frysinger vapier at gentoo.org
Tue Mar 30 09:33:14 CEST 2010


On Tuesday 30 March 2010 01:38:33 Heiko Schocher wrote:
> initialize mac address with the value from "ethaddr", before
> doing some network commands. This is not in line with u-boot
> design principle "not to initalize not used devices", and
> maybe should go away, if there is a solution for passing
> the mac address to arm linux kernels.

NACK like i already said -- net drivers should only ever be reading 
eth_driver->enetaddr.  they should never touch the environment as the common 
net code takes care of this.

i would instead fix the fec_probe() to stop writing "ethaddr" since it already 
writes to eth_driver->enetaddr.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100330/4a1a6523/attachment.pgp 


More information about the U-Boot mailing list