[U-Boot] [PATCH 3/3] TI: TNETV107X EVM initial support

[Wolfgang Denk]

Dear Cyril Chemparathy,

In message <1269893792-15248-4-git-send-email-cyril at ti.com> you wrote:
> TNETV107X is a Texas Instruments SoC based on an ARM1176 core, and with a
> bunch on on-chip integrated peripherals.  This patch adds support for the
> TNETV107X EVM board.
> 
> Signed-off-by: Cyril Chemparathy <cyril at ti.com>
> ---
>  MAKEALL                           |    1 +
>  Makefile                          |    3 +
>  board/ti/tnetv107xevm/Makefile    |   49 ++++++++
>  board/ti/tnetv107xevm/config.mk   |   20 ++++
>  board/ti/tnetv107xevm/sdb_board.c |   66 +++++++++++
>  board/ti/tnetv107xevm/u-boot.lds  |   48 ++++++++
>  include/configs/tnetv107x_evm.h   |  225 +++++++++++++++++++++++++++++++++++++
>  7 files changed, 412 insertions(+), 0 deletions(-)
>  create mode 100644 board/ti/tnetv107xevm/Makefile
>  create mode 100644 board/ti/tnetv107xevm/config.mk
>  create mode 100644 board/ti/tnetv107xevm/sdb_board.c
>  create mode 100644 board/ti/tnetv107xevm/u-boot.lds
>  create mode 100644 include/configs/tnetv107x_evm.h

Entry to MAINTAINERS missing.

> diff --git a/Makefile b/Makefile
> index c0e73de..e723e7c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2936,6 +2936,9 @@ davinci_dm365evm_config :	unconfig
>  davinci_dm6467evm_config :	unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm926ejs dm6467evm davinci davinci
>  
> +tnetv107x_evm_config: unconfig
> +	@$(MKCONFIG) $(@:_config=) arm arm1176 tnetv107xevm ti tnetv107x
> +
>  imx27lite_config:	unconfig
>  	@$(MKCONFIG) $(@:_config=) arm arm926ejs imx27lite logicpd mx27

Please keep lists sorted - board names, and architectures. arm1176 has
no place among arm926ejs systems.

> diff --git a/board/ti/tnetv107xevm/u-boot.lds b/board/ti/tnetv107xevm/u-boot.lds
> new file mode 100644
> index 0000000..3afa17f
> --- /dev/null
> +++ b/board/ti/tnetv107xevm/u-boot.lds

Do you really need board specific linker scripts? Or would one common
linker script for all (or at least for most of the) boards be
sufficient?

> diff --git a/include/configs/tnetv107x_evm.h b/include/configs/tnetv107x_evm.h
> new file mode 100644
> index 0000000..795e3f1
> --- /dev/null
> +++ b/include/configs/tnetv107x_evm.h
...
> +/****************************************************************/
> +/* Architecture, CPU, etc.                                      */
> +/****************************************************************/

Incorrect multiline comment styile. Please fix globally.

> +#define MTDIDS_DEFAULT			"nand0=davinci_nand.0"
> +#define MTDPARTS_DEFAULT		"mtdparts=davinci_nand.0:"	\
> +						"1536k(uboot)ro,"	\
> +						"128k(params)ro,"	\
> +						"4m(kernel),"		\
> +						"-(filesystem)"

Is "davinci" correct here?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a theory that it's impossible to prove anything, but  I  can't
prove it.