[U-Boot] [PATCH 1/2 v3] net, fec_mxc: only setup the device enetaddr with eeprom value

Ben Warren biggerbadderben at gmail.com
Wed Mar 31 08:50:44 CEST 2010


Hi Heiko,

Much better.  Thanks, and sorry again for not responding sooner.

Wolfgang - please apply this to the current release.

On Tue, Mar 30, 2010 at 11:34 PM, Heiko Schocher <hs at denx.de> wrote:

> only fill the device enetaddr with the contents of the eeprom,
> not program it in mac address registers
>
> Signed-off-by: Heiko Schocher <hs at denx.de>

Acked-by: Ben Warren <biggerbadderben at gmail.com>

>

---
> - changes since v1 posted here:
>  http://lists.denx.de/pipermail/u-boot/2010-March/069192.html
>
>  - splitted in two patches as Wolfgang suggested
>
> - changes since v2 posted here:
>
>  http://lists.denx.de/pipermail/u-boot/2010-March/069244.html
>
>  - add comment from Ben and Mike:
>    - not to look in content from "ethaddr"
>    - only read the mac from eeprom to ethdevices enetaddr and
>      do not program it in mac address registers
>
>  drivers/net/fec_mxc.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index 5af9cdb..8c4ade5 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -752,7 +752,6 @@ static int fec_probe(bd_t *bd)
>        if (fec_get_hwaddr(edev, ethaddr) == 0) {
>                printf("got MAC address from EEPROM: %pM\n", ethaddr);
>                memcpy(edev->enetaddr, ethaddr, 6);
> -               fec_set_hwaddr(edev);
>        }
>
>        return 0;
> --
> 1.6.2.5
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>


More information about the U-Boot mailing list