[U-Boot] [PATCH] cmd_onenand.c: moved to standard subcommand handling

Wolfgang Denk wd at denx.de
Wed May 5 23:57:29 CEST 2010


Dear Frans Meulenbroeks,

In message <1269706476-20496-1-git-send-email-fransmeulenbroeks at gmail.com> you wrote:
> On the fly also fixed the following things:
> - write help talked about a parameter oob, but that one was not used, so
>   removed it from the help message.
> - the test command also allowed a force subcommand but didn't use it.
>   eliminated the code.
> - do_onenand made static
> - do_onenand contained
> 	int blocksize;
> 	...
> 	mtd = &onenand_mtd;
> 	this = mtd->priv;
> 	blocksize = (1 << this->erase_shift); 
>   As blocksize was not used the last two statements were unneeded so
>   removed them.
>   The first statement (mtd = ....) assigns to a global. Not sure if it
>   is needed, and since I could not test this, left the line for now
> 
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
> ---
>  common/cmd_onenand.c |  307 +++++++++++++++++++++++++++++++-------------------
>  1 files changed, 192 insertions(+), 115 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Life would be so much easier if we could  just  look  at  the  source
code.                                                   -- Dave Olson


More information about the U-Boot mailing list