[U-Boot] [PATCH v2] powerpc: Consolidate bootcount_{store|load} for PowerPC

Wolfgang Denk wd at denx.de
Thu May 6 23:29:07 CEST 2010


Dear Stefan Roese,

In message <1272444456-2502-1-git-send-email-sr at denx.de> you wrote:
> This patch consolidates bootcount_{store|load} for PowerPC by
> implementing a common version in arch/powerpc/lib/bootcount.c. This
> code is now used by all PowerPC variants that currently have these
> functions implemented.
> 
> The functions now use the proper IO-accessor functions to read/write the
> values.
> 
> This code also supports two different bootcount versions:
> 
> a) Use 2 seperate words (2 * 32bit) to store the bootcounter
> b) Use only 1 word (2 * 16bit) to store the bootcounter
> 
> Version b) was already used by MPC5xxx.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Acked-by: Detlev Zundel <dzu at denx.de>
> Cc: Michael Zaidman <michael.zaidman at gmail.com>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Kim Phillips <kim.phillips at freescale.com>
> Cc: Anatolij Gustschin <agust at denx.de>
> ---
> v2:
> - Replace CONFIG_SYS_BOOTCOUNT_USE_32BIT with CONFIG_SYS_BOOTCOUNT_SINGLEWORD
>   as suggested by Detlev
> - Use CONFIG_8xx for MPC8xx define section
> - Replace CONFIG_BOOTCOUNT_ADDR with CONFIG_SYS_BOOTCOUNT_ADDR
> 
>  arch/powerpc/cpu/mpc5xxx/cpu.c      |   20 --------
>  arch/powerpc/cpu/mpc8260/commproc.c |   24 ---------
>  arch/powerpc/cpu/mpc83xx/cpu.c      |   30 ------------
>  arch/powerpc/cpu/mpc8xx/commproc.c  |   26 ----------
>  arch/powerpc/cpu/ppc4xx/commproc.c  |   24 ---------
>  arch/powerpc/lib/Makefile           |    1 +
>  arch/powerpc/lib/bootcount.c        |   90 +++++++++++++++++++++++++++++++++++
>  7 files changed, 91 insertions(+), 124 deletions(-)
>  create mode 100644 arch/powerpc/lib/bootcount.c

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are some good people in it, but the orchestra as  a  whole  is
equivalent to a gang bent on destruction."      - John Cage, composer


More information about the U-Boot mailing list