[U-Boot] [PATCH] [PATCH V4]Save environment data to mmc.

[Lv Terry-R65388]

Hi Wolfgang Denk,

	Though a block offset macros is more suitable for a block device, block size can be changed.
	Thus I think a size offset is better to describe the offset.

	What do you think?

	Thanks~~

Yours
Terry 

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de] 
Sent: 2010年5月7日 6:22
To: Lv Terry-R65388
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] [PATCH V4]Save environment data to mmc.

Dear Terry Lv,

In message <12730401491046-git-send-email-r65388 at freescale.com> you wrote:
> This patch is to save environment data to mmc card.
> It uses interfaces defined in generic mmc.
> 
> Signed-off-by: Terry Lv <r65388 at freescale.com>
> ---
>  arch/arm/lib/board.c     |   14 +++--
>  arch/powerpc/lib/board.c |   16 +++--
>  common/Makefile          |    1 +
>  common/cmd_nvedit.c      |    3 +-
>  common/env_mmc.c         |  154 ++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 176 insertions(+), 12 deletions(-)  create mode 
> 100644 common/env_mmc.c
> 
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c index 
> f5660a9..b7174ea 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -347,6 +347,15 @@ void start_armboot (void)
>  	dataflash_print_info();
>  #endif
>  
> +#ifdef CONFIG_GENERIC_MMC
> +/* MMC initialization is called before relocating env.
> +   Thus It is required that operations like pin multiplexer 
> +   be put in board_init.
> +*/

Incorrect multiline comment style. Please fix globally.


> diff --git a/common/env_mmc.c b/common/env_mmc.c new file mode 100644 
> index 0000000..c9a9415
> --- /dev/null
> +++ b/common/env_mmc.c

Hm... I see a tendency to add more and more such files that all deal
with one sort of a block oriented storage device or another.  Should
we not try to generalize this?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
My play was a complete success.  The audience was a failure.