[U-Boot] [PATCH] ARM1136: Fix cache_flush() error and correct cpu_init_crit() comments

[George G. Davis]

Hello Wolfgang,

On Tue, May 11, 2010 at 4:56 AM, Wolfgang Denk <wd at denx.de> wrote:

> Dear "George G. Davis",
>
> In message <AANLkTimWgVcvJX0DlG7iC5XQB-cRZdUQxPvWUe3LPREx at mail.gmail.com>
> you wrote:
> >
> > > Why don't we have to invalidate/flush the I- and BT-Cache here? I.e.
> why
> > is it sufficient to clean & invalidate the D-Cache here, only, and remove
> > the existing I- and BT-Cache invalidation/flushing?
> >
> > Quite frankly I thought for sure that it was handled elsewhere but now
> > that I look I see that it's not.  Meanwhile, I don't think U-Boot is
> > typically susceptible to self-modifying-code issues anyway (?) and
>
> What has self-modifying-code to do with it? Proper cache handling is
> mandatory in manyother siutuations as well, including when you load
> code (Linux kernel, standalone applications) and then try to execute
> these, or when dealing with I/O buffers, DMA, etc.
>
> > this isn't likely required but I suppose lack of I+BTB invalidation
>
> I think it is mandatory.
>

Yes, you're right.  New patch on the way shortly...

--
Regards,
George

>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> A direct quote from the Boss: "We passed over a lot of good people to
> get the ones we hired."
>