[U-Boot] [PATCH] Add support for LPC2468 from NXP

[Wolfgang Denk]

Dear Remco Poelstra,

In message <4BEA5C8B.6080800 at duran-audio.com> you wrote:
> Add support for LPC2468 from NXP
> 
> Basic startup code
> Internal flash is supported (for environment storage)
> 
> Signed-off-by: Remco Poelstra <remco.poelstra at duran-audio.com>
> ---
>   MAKEALL                                      |    1 +
>   Makefile                                     |    3 +

entry to MAINTAINERS file missing.

>   arch/arm/cpu/arm720t/cpu.c                   |    4 +-
>   arch/arm/cpu/arm720t/interrupts.c            |   39 ++-
>   arch/arm/cpu/arm720t/lpc24xx/Makefile        |   50 +++
>   arch/arm/cpu/arm720t/lpc24xx/flash.c         |  236 ++++++++++++
>   arch/arm/cpu/arm720t/lpc24xx/iap_entry.S     |    7 +
>   arch/arm/cpu/arm720t/start.S                 |   12 +-
>   arch/arm/include/asm/arch-lpc24xx/hardware.h |   32 ++
>   arch/arm/include/asm/arch-lpc24xx/immap.h    |  528 
> ++++++++++++++++++++++++++

And your patch is corrupted because your mailer wrapped long lines.



> diff --git a/arch/arm/cpu/arm720t/interrupts.c 
> b/arch/arm/cpu/arm720t/interrupts.c
> index eb8d425..06c4550 100644
> --- a/arch/arm/cpu/arm720t/interrupts.c
> +++ b/arch/arm/cpu/arm720t/interrupts.c
> @@ -29,17 +29,26 @@
>   #include <common.h>
>   #include <clps7111.h>
>   #include <asm/proc-armv/ptrace.h>
> +#if defined(CONFIG_LPC2468)
> +#include <asm/arch/immap.h>
> +#include <asm/io.h>
> +#else
>   #include <asm/hardware.h>
> +#endif

Please don't add any such board specific code to global files.

>   #ifndef CONFIG_NETARM
> +
> +#if defined(CONFIG_LPC2292)
> +#define TIMER_LOAD_VAL 0xffff
> +#define READ_TIMER (0xFFFFFFFF - GET32(T0TC))
> +#elif defined(CONFIG_LPC2468)
> +#define TIMER_LOAD_VAL 0
> +#define READ_TIMER (0xFFFFFFFF - 0xE0004008)
> +#else

Ditto.

NAK!

My review stops here. Please fix these immediate issues and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If in any problem you find yourself doing an immense amount of  work,
the answer can be obtained by simple inspection.