[U-Boot] [PATCH 4/4] Environment in MMC

[Stefano Babic]

Sudhakar Rajashekhara wrote:
> Hi Alagu,
> 
Hi,

> On Wed, May 12, 2010 at 15:08:27, Alagu Sankar wrote:
>> This patch is to save environment data to mmc card. It uses interfaces defined
>> in generic MMC framework.  This is enabled with CONFIG_ENV_IS_IN_MMC option.
>> Based on the earlier patch from Terry Lv at Freescale

Should be not better you send your comments to Terry as to generate a
new patch? His patch had already passed some reviews and he can
integrate your comments. I miss here what you changed respect Terry, and
you miss some comments in the previous reviews, for example regarding
the usage of the ALIGN macro. Why do you need two patches for the same
purpose ?

> Why this has been moved up? If there is any genuine reason for this, then
> you can mention it in patch description.

That is correct. The mmc must be initialized before env_init to get the
environment working.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================