[U-Boot] [PATCH 4/4] Environment in MMC

Stefano Babic sbabic at denx.de
Fri May 14 13:40:32 CEST 2010


Alagu Sankar wrote:

>>   
> When I searched for the Environment support in MMC, I came across
> Terry's earlier patches, but they were not cleanly getting applied to
> the current tree.

I have tried to apply again last Terry's patch, I see only a couple of
coding-style problems, no errors at all:

Applying: Save environment data to mmc.
/home/stefano/Projects/imx/u-boot-imx/.git/rebase-apply/patch:21:
trailing whitespace.
 * Thus It is required that operations like pin multiplexer
/home/stefano/Projects/imx/u-boot-imx/.git/rebase-apply/patch:54:
trailing whitespace.
 * Thus It is required that operations like pin multiplexer
warning: 2 lines add whitespace errors.

>  There is no value add here except fixing the patch
> errors and generating a new patch for the current tree.

Probably not needed. I have not seen the errors you reported. Are you
sure you have tested with Terry's last patch ? It seems you submit an
earlier version.

>  So there is no
> question of adding any copyright here.

Yes, Wolfgang has already answered. No need to add a copyright for small
patches.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list