[U-Boot] [PATCH v1 1/3] fsl-diu: Using I/O accessor to CCSR space

Wolfgang Denk wd at denx.de
Mon May 17 23:37:39 CEST 2010


Dear Dave Liu,

In message <1270713367-542-1-git-send-email-daveliu at freescale.com> you wrote:
> From: Jerry Huang <Chang-Ming.Huang at freescale.com>
> 
> Using PPC I/O accessor to DIU I/O space instead of directly
> read/write. It will prevent the dozen of compiler order issue
> and PPC hardware order issue for accessing I/O space.
> 
> Using the toolchain(tc-fsl-x86lnx-e500-dp-4.3.74-2.i386.rpm)
> can show up the order issue of DIU driver.
> 
> Signed-off-by: Dave Liu <daveliu at freescale.com>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang at freescale.com>
> ---
> * address Timur's comments
> 
>  board/freescale/common/fsl_diu_fb.c |   55 ++++++++++++++++++-----------------
>  1 files changed, 28 insertions(+), 27 deletions(-)

It seems this commit is causing a lot of build warnings:

...
Configuring for aria board...
../../../../board/freescale/common/fsl_diu_fb.c: In function 'fsl_diu_init':
../../../../board/freescale/common/fsl_diu_fb.c:271: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
../../../../board/freescale/common/fsl_diu_fb.c:272: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
../../../../board/freescale/common/fsl_diu_fb.c:273: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
../../../../board/freescale/common/fsl_diu_fb.c:335: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
../../../../board/freescale/common/fsl_diu_fb.c:336: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
../../../../board/freescale/common/fsl_diu_fb.c: In function 'fsl_diu_enable_panel':
../../../../board/freescale/common/fsl_diu_fb.c:395: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
../../../../board/freescale/common/fsl_diu_fb.c: In function 'fsl_diu_disable_panel':
../../../../board/freescale/common/fsl_diu_fb.c:406: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
...
Configuring for mpc5121ads board...
fsl_diu_fb.c: In function 'fsl_diu_init':
fsl_diu_fb.c:271: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
fsl_diu_fb.c:272: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
fsl_diu_fb.c:273: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
fsl_diu_fb.c:335: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
fsl_diu_fb.c:336: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
fsl_diu_fb.c: In function 'fsl_diu_enable_panel':
fsl_diu_fb.c:395: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast
fsl_diu_fb.c: In function 'fsl_diu_disable_panel':
fsl_diu_fb.c:406: warning: passing argument 2 of 'out_be32' makes integer from pointer without a cast

etc.



Patch following, but could you please run MAKEALL on your submissions?
Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Peace was the way.
	-- Kirk, "The City on the Edge of Forever", stardate unknown


More information about the U-Boot mailing list