[U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c
Timur Tabi
timur at freescale.com
Fri May 21 20:36:47 CEST 2010
Scott Wood wrote:
>> Doh. Git commit delete those lines because they began with a "#".
>
> Hmm... is there any way to override that and insert such a line into a
> git commit?
I was going to just insert a blank space or some other character before the #.
> I think the board header file (or some header factored out from a set of
> similar boards, which the board header includes) is exactly where it
> belongs, given that it's implemented in a board C file, and the C call
> is not a public API.
Well, you'll have to convince Wolfgang of that, not me. He won't accept my
P1022DS board patch until I fix this "problem".
> Some boards just hard code it as a constant.
> Others might want to call some other function, maybe with arguments (in
> fact, I see a dummy argument of zero passed in many if not all existing
> calls to these functions -- why?).
Probably some legacy stuff. Once this issue is resolved, I'll probably post
a patch that unifies the functions in some way.
--
Timur Tabi
Linux kernel developer at Freescale
More information about the U-Boot
mailing list