[U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c
Scott Wood
scottwood at freescale.com
Fri May 21 20:44:24 CEST 2010
On 05/21/2010 01:36 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>>> Doh. Git commit delete those lines because they began with a "#".
>>
>> Hmm... is there any way to override that and insert such a line into a
>> git commit?
>
> I was going to just insert a blank space or some other character before the #.
>
>> I think the board header file (or some header factored out from a set of
>> similar boards, which the board header includes) is exactly where it
>> belongs, given that it's implemented in a board C file, and the C call
>> is not a public API.
>
> Well, you'll have to convince Wolfgang of that, not me. He won't accept my
> P1022DS board patch until I fix this "problem".
I think the "some header factored out from a set of similar boards" (or
possibly similar board support idioms) approach would meet his request,
though doing that at too fine-grained a level could lead to an
unreadable tangle of header files and/or ifdefs.
-Scott
More information about the U-Boot
mailing list