[U-Boot] [PATCH V2] Tools: set multiple variable with fw_setenv utility

Stefano Babic sbabic at denx.de
Mon May 24 10:18:25 CEST 2010


Peter Tyser wrote:
> Hi Stefano,
> 

Hi Peter,

> It'd be nice to document the new functionality you're adding.  Any
> interest in adding a runtime usage message?  It seems like that'd be
> pretty useful.  At a minimum it would be nice to update the description
> in fw_env_main.c to reflect the changes you're making and/or update the
> README.

Agree. I think I will add a -h (help) option in fw_env_main.c, as you
suggest, describing in details how to call the utility.

> Is there a reason to keep fw_env_open around?  It looks like just a call
> to env_init() after the changes above?

The reason is to provide a classical file I/O interface, allowing to use
these utilities as library, too. This is consistent and more
comprehensive: the API is realized by fw_env_open, fw_env_write and
fw_env_close.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list