[U-Boot] [PATCH] Improve DaVinci SPI speed

[Delio Brignoli]

Hello Wolfgang,

On 24/05/2010, at 22:48, Wolfgang Denk wrote:
> In message <15866EAE-624B-4850-B10F-78AB99E3A1A2 at audioscience.com> you wrote:
>> 
>> On 21/05/2010, at 15:13, Wolfgang Denk wrote:
>>>> +				*rxp = buf_reg_val & 0xFF;	
>>>> +				rxp++;
>>>> +			}
>>> 
>>> Please change into:
>>> 
>>> 			if (rxp)
>>> 				*rxp++ = buf_reg_val & 0xFF;
>> 
>> Are you sure? Is folding that 3 line block into a one liner really worth
>> the loss of readability? I know what that means, so do you and many
>> others on this ML, but that's bound to raise a few eyebrows. A quick
> 
> Removing the need for braces is a good thing.

by making the code less intelligible, which is a bad thing.

> This is plain C, without any tricks or loopholes.

This is C, the hard-to-read kind, but you refuse to acknowledge that by stating
only your side of the argument, while I pointed out the tradeoff involved and my opinion.
I have no inclination to argue in this fashion :-)

Kind Regards
--
Delio

> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Build a system that even a fool can use and only a fool will want  to
> use it.