[U-Boot] [PATCH] arm:io.h: define __io() macro if not defined erlier

[Wolfgang Denk]

Dear =?ISO-8859-1?Q?Andreas_Bie=DFmann?=,

In message <4BFB8708.4010408 at corscience.de> you wrote:
>
> Warnings appeared due to too little testing on my side ... sorry for
> that. Is there an easy way to build all e.g. arm-related
> boards/configuration-sets in a test run?

Sure, and it's documented.

Try:

	./MAKEALL arm

> We should discuss where to fix this issue.

Thanks for addressing this.  At the moment this issue is blocking the
-rc1 pre-release, so I really appreciate if we could find a working
solution for this quickly.

> It is a fact that commit a45dde2293c816138e53c26eca6fd0322583f9a6 breaks
> compilation of arm boards using dm9000x driver.
> 
> Another fact is that mostly all arch/asm/io.h defines {in|out}[bxl]
> macros except for arm (and sparc, they name them __arch_{put|get}[bwl]).
> Arm defines them conditionally only if the macro __io(p) is defined.
> By some reason omap1510 defines his own {in|out}[bxl]. My first argument
> for removing this is that this boards definition is the only one
> defining his own {in|out}[bxl] -> '# grep -nr outb\( include/configs/'
> The second one is that kind of the definition is so common to put it in
> generic arch/asm/io.h.

Makes sense to me, especially since the omap1510 code is very old, so
we can assume it has not been adapted to later generalizations of such
code.

> The other way around we could define the {in|out}[bxl] macros everywhere
> is needed in board specific configuration files. Namely there are at least:

This does not sound attractive at all.

> I'm willing to build another patch but like to have this discussed before.

Thanks.

> I think the easiest way to solve this is to create another patch
> including exactely the changes sent before plus removing {in|out}[bxl]
> macros in omap1510.h.

Sounds like a plan to me.

Best regards,


Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Eureka!                                                 -- Archimedes