[U-Boot] [PATCH] watchdog petting during autoboot delay

[Mike Frysinger]

On Wednesday 26 May 2010 06:34:49 Nicolas Ferre wrote:
> --- a/common/main.c
> +++ b/common/main.c
> @@ -159,6 +159,7 @@ static __inline__ int abortboot(int bootdelay)
>  	 * when catch up.
>  	 */
>  	do {
> +		WATCHDOG_RESET();	/* Trigger watchdog, if needed */
>  		if (tstc()) {
>  			if (presskey_len < presskey_max) {
>  				presskey [presskey_len ++] = getc();
> @@ -251,6 +252,7 @@ static __inline__ int abortboot(int bootdelay)
>  # endif
>  				break;
>  			}
> +			WATCHDOG_RESET();	/* Trigger watchdog, if needed */
>  			udelay(10000);
>  		}

if your udelay() implementation isnt calling WATCHDOG_RESET(), it is broken.  
yes, this is undocumented, but search the mailing archives for examples.

i believe the same goes for serial devices and their tstc() function.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100526/b8888d0f/attachment.pgp