[U-Boot] [PATCH 02/17] GRETH: Added support for selecting PHY address from config, PHY address was always set to zero before.

[Wolfgang Denk]

Dear Daniel Hellstrom,

In message <1274194143-8994-1-git-send-email-daniel at gaisler.com> you wrote:
> Signed-off-by: Daniel Hellstrom <daniel at gaisler.com>
> ---
>  drivers/net/greth.c |   69 +++++++++++++++++++++++++++++++-------------------
>  1 files changed, 43 insertions(+), 26 deletions(-)

Sorry for the late review...

> +#ifdef CONFIG_SYS_GRLIB_GRETH_PHYADDR
> +	int phyaddr = CONFIG_SYS_GRLIB_GRETH_PHYADDR;
> +#else
> +	int phyaddr = 0;
> +#endif

Please make this:

#ifndef	CONFIG_SYS_GRLIB_GRETH_PHYADDR
#define CONFIG_SYS_GRLIB_GRETH_PHYADDR	0
#endif
int phyaddr = CONFIG_SYS_GRLIB_GRETH_PHYADDR;


> +#ifdef DEBUG
> +			printf("greth_init_phy: PHY read 1 failed\n");
> +#endif
...
> +#ifdef DEBUG
> +			printf("greth_init_phy: PHY read 2 failed\n");
> +#endif

Please change all these into debug() calls and drop the #ifdef's.

Also, this patch needs to go through Ben's networking repository.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do you suppose the reason the ends of the `Intel Inside'  logo  don't
match up is that it was drawn on a Pentium?