[U-Boot] [PATCH 06/17] LEON3: Moved GRLIB core header files to common include/grlib directory
Wolfgang Denk
wd at denx.de
Wed May 26 23:01:57 CEST 2010
Dear Daniel Hellstrom,
In message <1274194143-8994-5-git-send-email-daniel at gaisler.com> you wrote:
> Signed-off-by: Daniel Hellstrom <daniel at gaisler.com>
> ---
> arch/sparc/cpu/leon3/cpu_init.c | 10 +--
> arch/sparc/cpu/leon3/interrupts.c | 7 +-
> arch/sparc/cpu/leon3/memcfg.h | 1 -
> arch/sparc/cpu/leon3/prom.c | 7 ++-
> arch/sparc/cpu/leon3/serial.c | 16 ++--
> drivers/net/greth.c | 2 +-
> include/ambapp.h | 137 -------------------------------------
> include/grlib/apbuart.h | 63 +++++++++++++++++
> include/grlib/gptimer.h | 50 +++++++++++++
> include/grlib/greth.h | 103 ++++++++++++++++++++++++++++
> include/grlib/irqmp.h | 39 +++++++++++
> 11 files changed, 277 insertions(+), 158 deletions(-)
> create mode 100644 include/grlib/apbuart.h
> create mode 100644 include/grlib/gptimer.h
> create mode 100644 include/grlib/greth.h
> create mode 100644 include/grlib/irqmp.h
...
> --- /dev/null
> +++ b/include/grlib/apbuart.h
> @@ -0,0 +1,63 @@
> +/* GRLIB APBUART definitions
> + *
> + * (C) Copyright 2010
> + * Daniel Hellstrom, Aeroflex Gaisler, daniel at gaisler.com
...
Incorrect multiline comment style.
OK, I give up review on this patch series now. Please apply all
previously made review comments globally, to all patches in this
series.
Then resubmit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Drawing on my fine command of language, I said nothing.
More information about the U-Boot
mailing list