[U-Boot] [PATCH] libfdt: introduce function fdt_get_max_phandle

Jerry Van Baren gvb.uboot at gmail.com
Thu May 27 04:38:51 CEST 2010


Wolfgang Denk wrote:
> Dear Timur Tabi,
> 
> In message <1274308618-2974-1-git-send-email-timur at freescale.com> you wrote:
>> Introduce function fdt_get_max_phandle(), which returns the largest value
>> of all phandles in a device tree.  This is useful for allocating a new phandle
>> property, since all phandles must be unique.
>>
>> Signed-off-by: Timur Tabi <timur at freescale.com>
>> ---
>>  include/libfdt.h    |   20 ++++++++++++++++++++
>>  lib/libfdt/fdt_ro.c |   17 +++++++++++++++++
>>  2 files changed, 37 insertions(+), 0 deletions(-)
> 
> Please submit as part of a patch / patch series that acrtually uses
> this feature.  As is, it's just dead code that has no users.

I'm happy with this in principle, and will <ack> formally when the 
community is OK with the code change.  It looks like a positive 
improvement to me, reducing complexity and addressing Timur/Freescale's 
needs.  Anyway, I envision <acking> the patch and having FSL include it 
in whatever MPC8xxx patchset that actually needs the changes.

Thanks and best regards,
gvb

[snip improvement suggestion]


More information about the U-Boot mailing list