[U-Boot] [PATCH] 85xx/p2020ds: Use is_serdes_configured() to determine of PCIe enabled

[Kumar Gala]

On May 27, 2010, at 2:08 AM, Wolfgang Denk wrote:

> Dear Kumar Gala,
> 
> In message <1274433478-31849-2-git-send-email-galak at kernel.crashing.org> you wrote:
>> The new is_serdes_configured covers a broader range of devices than the
>> PCI specific code.  Use it instead as we convert away from the
>> is_fsl_pci_cfg() code.
>> 
>> Additionally move to setting LAWs for PCI based on if its configured.
>> Also updated PCI FDT fixup code to remove PCI controllers from dtb if
>> they are not configured.
> ...
>> #ifdef CONFIG_PCIE3
>> 	ft_fsl_pci_setup(blob, "pci0", &pcie3_hose);
>> +#else
>> +	ft_fsl_pci_setup(blob, "pci0", NULL);
>> #endif
>> #ifdef CONFIG_PCIE2
>> 	ft_fsl_pci_setup(blob, "pci1", &pcie2_hose);
>> +#else
>> +	ft_fsl_pci_setup(blob, "pci1", NULL);
>> #endif
>> #ifdef CONFIG_PCIE1
>> 	ft_fsl_pci_setup(blob, "pci2", &pcie1_hose);
>> +#else
>> +	ft_fsl_pci_setup(blob, "pci2", NULL);
>> #endif
> 
> As Timur already pointed out: can we please clean up this mess of
> 3 = 0 = 3, 2 = 1 = 2, 1 = 2 = 1?
> 
> This is extremely confusing.

This is my fault.  However not sure what to do about it since we'd break compatibility with kernel .dts to clean this up.

99% of the u-boot code should match the HW docs.  In this one place I tried to "rename" things such that it made sense.  The pci aliases in the .dts are in order of address (so whatever HW controller is @ 0x8000 would be "pci0", 0x9000 - "pci1", etc.)

- k