[U-Boot] [PATCH 10/11] at91sam9263ek: make compilable again

Wolfgang Denk wd at denx.de
Mon Nov 1 10:39:48 CET 2010


Dear Alexander Stein,

In message <1288600195-6960-11-git-send-email-alexander.stein at systec-electronic.com> you wrote:
> Signed-off-by: Alexander Stein <alexander.stein at systec-electronic.com>
> ---
>  board/atmel/at91sam9263ek/at91sam9263ek.c |    6 +++---
>  include/configs/at91sam9263ek.h           |   15 +++++++++++----
>  2 files changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/board/atmel/at91sam9263ek/at91sam9263ek.c b/board/atmel/at91sam9263ek/at91sam9263ek.c
> index 91efc07..c9c8eac 100644
> --- a/board/atmel/at91sam9263ek/at91sam9263ek.c
> +++ b/board/atmel/at91sam9263ek/at91sam9263ek.c
> @@ -252,7 +252,7 @@ int board_init(void)
>  	/* arch number of AT91SAM9263EK-Board */
>  	gd->bd->bi_arch_number = MACH_TYPE_AT91SAM9263EK;
>  	/* adress of boot parameters */
> -	gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
> +	gd->bd->bi_boot_params = CONFIG_SYS_SDRAM_BASE + 0x100;

PLease refactor these patches.  The rename PHYS_SDRAM =>
CONFIG_SYS_SDRAM_BASE was done in an earlier patch, so this and
similar changes in other patches should be part of that rename patch.

The rename patch should contain _all_ such renames, like any patch
should contain all modifications that belong to it logically.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
G's Third Law:             In spite of all evidence  to  the  contra-
ry,  the  entire  universe  is composed of only two basic substances:
magic and bullshit.
H's Dictum:                There is no magic ...


More information about the U-Boot mailing list